refactor alert dialog styles, use vscode theme #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dosubot
bot
added
size:M
Collaborator
|
Thank you! |
cte
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The alert dialogs were not reflecting the currently set VS Code Theme.
I fixed the styles and also changed the button naming from "No/Yes" to "Cancel / Discard changes" to follow design principles for better User Experience.
This fixes #1469
This fixes also the alert dialog popping up when deleting tasks in history.
Implementation
The alert dialogs weren't using vscode css styles. I added them.
Screenshots
How to Test
Settings Page: Change settings in the settings page and move click on another menu item like "prompts" without saving before.
Task History: Click on the delete icon of a task in the task history
Important
Refactor alert dialog styles to use VS Code theme and improve button labels for better UX.
alert-dialog.tsxto use VS Code theme colors and styles.SettingsView.tsxfrom "Yes/No" to "Discard changes/Cancel" for clarity.AlertTriangleicon toAlertDialogTitleinSettingsView.tsxfor visual emphasis.AlertDialogFooterlayout inalert-dialog.tsxfor better button alignment.This description was created by
for 8c21f0e. It will automatically update as commits are pushed.